Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loader: make behaviour consistent with Beam Enrich #111

Open
simplylizz opened this issue Jun 30, 2020 · 0 comments
Open

Loader: make behaviour consistent with Beam Enrich #111

simplylizz opened this issue Jun 30, 2020 · 0 comments

Comments

@simplylizz
Copy link
Contributor

simplylizz commented Jun 30, 2020 •
edited
Loading

  1. Different arg name for dataflow jobs: --job-name for enricher vs --jobName for the loader.
  2. Enricher fails if a job name isn't specified, the loader generates it (I think the first is preferred since they use the same input/output resources and conflicts here may have an unpredictable effect; also job-name is unique within dataflow project and allows you to update your pipelines).
  3. Enricher exits after launching a pipeline while the loader hangs and outputs some info into console.

I think it would be nice to have consistent behavior.
@dilyand dilyand added this to the 0.7.0 milestone Feb 4, 2021
@dilyand dilyand changed the title Loader and enricher inconsistent behaviour Loader: make behaviour consistent with Beam Enrich Feb 12, 2021
@dilyand dilyand removed this from the 1.0.0 milestone Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simplylizz @dilyand