FIXED: Purchase Cost Column Always Shown #16531
Merged
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXED: The purchase cost column was always being shown, even if the checkbox wasn't ticked in the custom reports. The logic on the line for the column was also checking for depreciation, and thus, would populate the header for the column, even though we do not gather the data for depreciation to then fill that field.
This fixes the line for that logic so that it will properly disappear when the option is not selected.
Admittedly, we should put depreciation somewhere in the custom report. the current value of an asset is something that users probably will want.
(EDIT: so we do have this, its just not in an obvious spot next to the purchase cost)