Skip to content

FIXED: Purchase Cost Column Always Shown #16531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025

Conversation

akemidx
Copy link
Member

@akemidx akemidx commented Mar 18, 2025

FIXED: The purchase cost column was always being shown, even if the checkbox wasn't ticked in the custom reports. The logic on the line for the column was also checking for depreciation, and thus, would populate the header for the column, even though we do not gather the data for depreciation to then fill that field.

CleanShot 2025-03-18 at 12 26 53@2x

This fixes the line for that logic so that it will properly disappear when the option is not selected.

Screenshot 2025-03-18 at 4 42 19 PM

Admittedly, we should put depreciation somewhere in the custom report. the current value of an asset is something that users probably will want.
(EDIT: so we do have this, its just not in an obvious spot next to the purchase cost)

@akemidx akemidx requested a review from marcusmoore March 18, 2025 20:48
@akemidx akemidx requested a review from snipe as a code owner March 18, 2025 20:48
Copy link

what-the-diff bot commented Mar 18, 2025

PR Summary

  • Updated Condition in postCustom Method
    The requirement for performing an action has been simplified. Previously, for making an entry in an array, two conditions needed to be met - data should be available in both purchase_cost and depreciation fields. With this update, the entry can be made if the purchase_cost field alone is filled. This change should make the process smoother and more efficient.

Copy link
Collaborator

@marcusmoore marcusmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏾

@snipe snipe merged commit 43c310c into grokability:develop Apr 30, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants