Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for some ion mobility files #706

Open
sneumann opened this issue Dec 11, 2023 · 1 comment
Open

Add tests for some ion mobility files #706

sneumann opened this issue Dec 11, 2023 · 1 comment

Comments

@sneumann
Copy link
Owner

sneumann commented Dec 11, 2023

Hi,
we should test the reading and peak picking functions some time in the future how well it handles peculiarities in IMS data.
An addendum to the mzML spec says:

There was some concern that in the original mzML 1.1 format there should never be two 
identical m/z values in an “m/z array”. But this was not explicitly stipulated in the mzML 1.1 
specification, and with the addition of ion mobility arrays, repetition in the “m/z array” will be 
common (having differing ion mobility array values). This means that all mzML parsers SHOULD 
be checked/updated to handle mzML data with non-increasing (identical or decreasing) m/z values 
in the "m/z array". All parsers SHOULD also be updated to warn or halt gracefully if they are not prepared 
to handle the kinds of data described herein.

This has time until a suitable collection of example mzMLs are available,
but I wanted to note this somewhere for reference.
Yours, Steffen

@jorainer
Copy link
Collaborator

Good point. In some functions in Spectra (and for some backends) we check if or ensure that m/z values are ordered. AFAIK all our functionality should be safe even if m/z values are not ordered. The only functions where it is critical are the m/z comparison, grouping and binning functions in MsCoreUtils. But these by default check for ordered m/z values.

xcms uses now also Spectra et al - so it should suffice if we fix it there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants