Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work quite right with transparent images #83

Open
rinogo opened this issue May 3, 2022 · 2 comments
Open

Doesn't work quite right with transparent images #83

rinogo opened this issue May 3, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@rinogo
Copy link

rinogo commented May 3, 2022

When using images with an alpha channel (e.g. transparent PNGs), the existing masking approach doesn't work quite right.

The current approach assumes that .first-overlay will cover .second. When transparent images are in use, that's not a safe assumption - .second "shows through" where it shouldn't.

Fortunately, I was able to find a workaround in which I composited my background onto the images themselves. However, for a fully responsive design, it would be better to support transparent images natively.

@sneas sneas added the enhancement New feature or request label May 4, 2022
@sneas
Copy link
Owner

sneas commented May 4, 2022

Thank you for the feedback, @rinogo. I'll think about how to incorporate it in the future versions of the project.

@alexd3d
Copy link

alexd3d commented Feb 1, 2023

There is native workaround - just assign some background on img. I.e. img {background: white;} and they will not see-through each other

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants