Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more flexible resource specifications #175

Open
lczech opened this issue Dec 9, 2024 · 4 comments
Open

Allow more flexible resource specifications #175

lczech opened this issue Dec 9, 2024 · 4 comments

Comments

@lczech
Copy link

lczech commented Dec 9, 2024

Is your feature request related to a problem? Please describe.
Slurm allows for intuitive specifications of resources, such as 10G of memory, and 1-0 days of runtime. As far as I could figure out from the documentation and the code here though, these are not supported, and instead are cumbersome, such as 10000 for mem_mb, and the even weirder 1440 minutes in a day...

Describe the solution you'd like
I'd like the plugin to support the same resource formatting options as slurm.

@cmeesters
Copy link
Member

That is already possible. It is just that the documentation is lagging behind, I'm afraid. I will happily consider a PR — and am planning an overhaul for a while now. Possible before Christmas, myself.

@lczech
Copy link
Author

lczech commented Dec 11, 2024

Oh I see, thanks! So, to get this right: These two would then be equivalent:

mem: 1G
mem_mb: 1000

Or how is this meant to be used?

@cmeesters
Copy link
Member

cmeesters commented Dec 11, 2024

I need to look this up and am on a rush, right now. If I recall correctly, SLURM silently considers MiB and GiB, not MB or GB.

Snakemake makes this distinction.

@lczech
Copy link
Author

lczech commented Dec 13, 2024

Thank you! However, at least for the runtime, it does not quite seem to work the same as slurm. When I specify 2-0, which is two days in slurm, the job gets submitted with two hours instead.

Edit: Also, I just tried 48:00:00, which should mean two days in slurm, but it got translated to 120 days instead, which does not make sense to me. Something is not quite right there, although I can't quite tell what's going there. Let me know if I can further help to debug this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants