Thunk: using selector of underlaying view

[wclr]

Thunk uses currently its own selector (sel) fully disregarding and replacing the selector of passed view in the resulting node. To be consistent more often one has to duplicate into a thunk selector (which defines at least node's tag) that is used in a view function, that is just a lazy wrapper around a given view.

What if thunk didn't replace the selector of the underlying view? This could be accomplished with several tweaks:

Use thunk selector to compare nodes and not use it in the resulting view, but this does not require a selector but some kind of key, though we already have the key (actually key and selector always seemed to have a kind of overlapping intentions). So probably the selector could be just removed and the thunk key is required(?).

If now calculated view's selector is used then it could be used to compare nodes to understand if the node has to be recreated.

So maybe I missing something and the current thunk design has more important considerations underneath?

@paldepind @jvanbruegge

[jvanbruegge]

I never used thunks, so i cannot really give an informed answer

[kuraga]

@wclr , what's your proposition? :) And which lines of code we have to reconsider?

[wclr]

Here in copyToThunk sel is not copied from a target view. And probably sameNode have to be reconsidered.