Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperx to Snabbdom #243

Closed
jorgebucaran opened this issue Feb 8, 2017 · 5 comments
Closed

Hyperx to Snabbdom #243

jorgebucaran opened this issue Feb 8, 2017 · 5 comments

Comments

@jorgebucaran
Copy link
Contributor

jorgebucaran commented Feb 8, 2017

I created hyperx-to-snabbdom a few months ago as an approach to solving choojs/hyperx/issues/36 in a non-opinionated manner that could satisfy as many library authors as possible.

It works for my use case, but I'd be curious to hear your feedback about it.

Cheers and thanks for the awesome work you're doing here.

@graforlock
Copy link
Contributor

graforlock commented Oct 4, 2017

Have a look at my fork of your solution (i did it like this as you only have a gist) , the original adds additional, redundant space everywhere (as a result of template string newlines), and it should probably just add it in text nodes

@jorgebucaran
Copy link
Contributor Author

Thanks! @graforlock I'll update my gist and publish a new minor.

@graforlock
Copy link
Contributor

It may have more cases like these and needs some testing I believe

@jorgebucaran
Copy link
Contributor Author

jorgebucaran commented Oct 5, 2017

@graforlock I am not really using Snabbdom, hyperx etc., anymore, having moved to Hyperapp, but I might turn it into a repo with tests someday just because. :)

@jorgebucaran
Copy link
Contributor Author

@graforlock Published 1.1.0. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants