Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow type checking with snabbdom 3.6+ #1114

Open
schlawg opened this issue Mar 16, 2024 · 1 comment
Open

Slow type checking with snabbdom 3.6+ #1114

schlawg opened this issue Mar 16, 2024 · 1 comment

Comments

@schlawg
Copy link

schlawg commented Mar 16, 2024

Recent releases after 3.5.1 seem to really trouble tsc.

We import and use snabbdom from ~ 31 modules of a monorepo.

Our type checking takes 3x as long when those modules import snabbdom 3.6 vs 3.5.1.

48s vs 14s

@paldepind
Copy link
Member

Hi @schlawg. Thanks for reporting this. That is quite a noticeable slowdown. Would it be possible for you to git bisect this to figure out what caused the issue?

One thing I can think of regarding typing is that the types for JSX was improved in #1092.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants