Skip to content

Commit 5623514

Browse files
committed
update android version and remove livedata handling
1 parent 2ac5ab1 commit 5623514

File tree

14 files changed

+39
-166
lines changed

14 files changed

+39
-166
lines changed

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
apply from: 'dependencies.gradle'
33

44
buildscript {
5-
ext.kotlin_version = '1.6.10'
5+
ext.kotlin_version = '1.8.10'
66
repositories {
77
google()
88
mavenCentral()

kcore/src/main/java/com/past3/ketro/kcore/model/Kexception.kt

Lines changed: 0 additions & 9 deletions
This file was deleted.

ketro/build.gradle

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@ apply plugin: 'kotlin-android'
33
apply plugin: 'kotlin-kapt'
44

55
android {
6-
compileSdkVersion 33
6+
compileSdkVersion 34
77

88

99
defaultConfig {
10-
minSdkVersion 16
11-
targetSdkVersion 33
10+
minSdkVersion 30
11+
targetSdkVersion 34
1212
versionCode 4
1313
versionName "1.4"
1414

@@ -35,20 +35,15 @@ android {
3535

3636
dependencies {
3737
implementation fileTree(dir: 'libs', include: ['*.jar'])
38-
implementation 'androidx.appcompat:appcompat:1.4.2'
3938
implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version"
4039
implementation 'androidx.lifecycle:lifecycle-extensions:2.2.0'
41-
implementation 'androidx.lifecycle:lifecycle-viewmodel-ktx:2.4.1'
42-
implementation 'com.squareup.retrofit2:retrofit:2.6.0'
43-
implementation 'com.squareup.retrofit2:converter-gson:2.3.0'
40+
implementation 'com.squareup.retrofit2:retrofit:2.9.0'
41+
implementation 'com.squareup.retrofit2:converter-gson:2.9.0'
4442

45-
kapt 'androidx.lifecycle:lifecycle-compiler:2.4.1'
4643
testImplementation 'junit:junit:4.13.2'
4744
testImplementation "org.mockito:mockito-core:$mockitoCoreVersion"
4845
testImplementation "org.mockito:mockito-inline:$mockitoInlineVersion"
4946
testImplementation "com.nhaarman.mockitokotlin2:mockito-kotlin:$mockitoKotlinVersion"
50-
api project(path: ':kcore')
51-
api project(path: ':request')
5247
}
5348
repositories {
5449
google()

ketro/src/main/java/com/past3/ketro/api/ApiCallback.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package com.past3.ketro.api
22

3-
import com.past3.ketro.kcore.model.StatusCode
3+
import com.past3.ketro.api.model.StatusCode
44
import retrofit2.Call
55
import retrofit2.Callback
66

@@ -12,6 +12,7 @@ abstract class ApiCallback<T>(private val errorHandler: ApiErrorHandler) : Callb
1212
in 200 until 209 -> {
1313
handleResponseData(response.body(), statusCode)
1414
}
15+
1516
else -> {
1617
handleError(response, statusCode)
1718
}

ketro/src/main/java/com/past3/ketro/api/ApiErrorHandler.kt

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package com.past3.ketro.api
22

3-
import com.past3.ketro.kcore.model.Kexception
4-
import com.past3.ketro.kcore.model.StatusCode
3+
import com.past3.ketro.api.model.KException
4+
import com.past3.ketro.api.model.StatusCode
55

66
/*
77
*ApiErrorHandler class should be extended to handle custom exceptions
@@ -15,7 +15,12 @@ open class ApiErrorHandler {
1515
* return a sub-type of kexception()
1616
*/
1717
open fun getExceptionType(response: retrofit2.Response<*>): Exception {
18-
return Kexception(response.errorBody(), response.message(), null, StatusCode(response.code()))
18+
return KException(
19+
response.errorBody(),
20+
response.message(),
21+
null,
22+
StatusCode(response.code())
23+
)
1924
}
2025

2126

ketro/src/main/java/com/past3/ketro/api/GenericRequestHandler.kt

Lines changed: 0 additions & 47 deletions
This file was deleted.

ketro/src/main/java/com/past3/ketro/api/Kobserver.kt

Lines changed: 0 additions & 52 deletions
This file was deleted.

ketro/src/main/java/com/past3/ketro/api/LiveDataHandler.kt

Lines changed: 0 additions & 30 deletions
This file was deleted.

ketro/src/main/java/com/past3/ketro/api/Request.kt

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
package com.past3.ketro.api
22

33
import androidx.annotation.VisibleForTesting
4-
import com.past3.ketro.kcore.model.KResponse
5-
import com.past3.ketro.kcore.model.StatusCode
6-
import com.past3.ketro.kcore.model.Wrapper
4+
import com.past3.ketro.api.model.KResponse
5+
import com.past3.ketro.api.model.StatusCode
6+
import com.past3.ketro.api.model.Wrapper
77
import retrofit2.Response
88

99
abstract class Request<out T : Any>(
10-
private val errorHandler: ApiErrorHandler = ApiErrorHandler()
10+
private val errorHandler: ApiErrorHandler = ApiErrorHandler()
1111
) {
1212

1313
abstract suspend fun apiRequest(): Response<out T>
@@ -19,6 +19,7 @@ abstract class Request<out T : Any>(
1919
in 200 until 209 -> {
2020
handleResponseData(resp.body(), statusCode)
2121
}
22+
2223
else -> {
2324
handleError(resp, statusCode)
2425
}
@@ -32,6 +33,7 @@ abstract class Request<out T : Any>(
3233
in 200 until 209 -> {
3334
KResponse.Success(resp.body(), statusCode)
3435
}
36+
3537
else -> {
3638
KResponse.Failure(errorHandler.getExceptionType(resp), statusCode)
3739
}
@@ -47,5 +49,4 @@ abstract class Request<out T : Any>(
4749
fun <T> handleError(response: Response<T>, statusCode: StatusCode): Wrapper<out T> {
4850
return Wrapper(errorHandler.getExceptionType(response), statusCode = statusCode)
4951
}
50-
51-
}
52+
}
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
package com.past3.ketro.api.model
2+
3+
import okhttp3.ResponseBody
4+
5+
6+
open class KException(val errorBody: ResponseBody?,
7+
message: String?,
8+
cause: Throwable?,
9+
val statusCode: StatusCode
10+
) : Exception(message, cause)

0 commit comments

Comments
 (0)