Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validations absent #5

Open
maheshm opened this issue Jul 25, 2013 · 9 comments
Open

Validations absent #5

maheshm opened this issue Jul 25, 2013 · 9 comments
Labels

Comments

@maheshm
Copy link

maheshm commented Jul 25, 2013

There is no validations in place as of now. For eg I can enter Alphanumeric things into year of publication of a book.

@ghost ghost assigned ershad Jul 31, 2013
@maheshm
Copy link
Author

maheshm commented Aug 2, 2013

Not part of the milestone. Reducing the priority to P1.

@maheshm
Copy link
Author

maheshm commented Aug 5, 2013

Reducing priority further, temporarily.

@Roshanjossey
Copy link
Contributor

Hey @maheshm, @ershad: I'd like to take this up and solve the issue.
Also I'd like to add some specs.
Any thoughts?

@ershad
Copy link
Member

ershad commented Feb 3, 2016

@Roshanjossey Please go ahead and do it 👍

@Roshanjossey
Copy link
Contributor

@ershad, I'm on it.
Do you have a vagrant box that I can use?
Which ISBN standard do we use?

@ershad
Copy link
Member

ershad commented Feb 8, 2016

@Roshanjossey There's no vagrant box configured right now. Currently we don't enforce any particular ISBN standard.

@Roshanjossey
Copy link
Contributor

@ershad, I've submitted a pull request for some changes I made to book model. I'd also like to do the same for other models too.
I have some questions about search model and some other stuff. Should we take it somewhere else?

@ershad
Copy link
Member

ershad commented Feb 10, 2016

@Roshanjossey Merged your pull request. I think it would be easy if we create Github issues for discussion, can you please do that?

@Roshanjossey
Copy link
Contributor

@ershad: Cool. I'll definitely do that. Right now I'm following an issue about build getting failed. #29
I sure to get answers for lot of my questions there. Thanks again.

@ershad ershad removed their assignment Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants