LESSON 9: checkUpkeep test

[cryptocambi]

All the test till the "checkUpkeep test are working. when I test the code:

describe("checkUpkeep", function () {
          it("returns false if ppl haven't sent any ETH", async function () {
              await raffle.enterRaffle({ value: raffleEntranceFee })
              await network.provider.send("evm_increaseTime", [interval.toNumber() + 1])
              await network.provider.send("evm_mine", [])
              const { upkeepNeeded } = await raffle.callStatic.checkUpkeep([])
              assert(!upkeepNeeded)
          })
      })

it give me the following error:

Raffle unit test
checkUpkeep
1) returns false if ppl haven't sent any ETH

0 passing (727ms)
1 failing

1. Raffle unit test
   checkUpkeep
   returns false if ppl haven't sent any ETH:
   AssertionError: Unspecified AssertionError
   at Context. (test\unit\Raffle.test.js:58:19)
   at processTicksAndRejections (node:internal/process/task_queues:95:5)
   at runNextTicks (node:internal/process/task_queues:64:3)
   at listOnTimeout (node:internal/timers:538:9)
   at processTimers (node:internal/timers:512:7)

However if I change line 58, that is:

assert(!upkeepNeeded) to assert(upkeepNeeded) it works

describe("checkUpkeep", function () {
it("returns false if ppl haven't sent any ETH", async function () {
await raffle.enterRaffle({ value: raffleEntranceFee })
await network.provider.send("evm_increaseTime", [interval.toNumber() + 1])
await network.provider.send("evm_mine", [])
const { upkeepNeeded } = await raffle.callStatic.checkUpkeep([])
assert(upkeepNeeded)
})
})

here you can see it works:

C:\Users\K\hh-fcc\hardhat-smartcontract-lottary-fcc\node_modules.bin\hardhat test --grep "returns false if ppl haven't sent any ETH"

Raffle unit test
checkUpkeep
✔ returns false if ppl haven't sent any ETH

1 passing (673ms)

Done in 5.07s.

Any explaination?

[parishill25]

@cryptocambi Share all your test code.

[cryptocambi]

I found the issue, but thank you for your availability

[HarshDev56]

@cryptocambi remove this line await raffle.enterRaffle({ value: raffleEntranceFee }) from

  it("returns false if ppl haven't sent any ETH", async function () {
              await raffle.enterRaffle({ value: raffleEntranceFee })
              await network.provider.send("evm_increaseTime", [interval.toNumber() + 1])
              await network.provider.send("evm_mine", [])
              const { upkeepNeeded } = await raffle.callStatic.checkUpkeep([])
              assert(!upkeepNeeded)
          })

then it work .

explanation for this answer

right now you have this line await raffle.enterRaffle({ value: raffleEntranceFee }) in your code mean it is return this stuff

isOpen  true
timePassed  true
hasPlayer  true
hasBalance  true
upkeepNeeded true

and we want that upkeepNeeded has to be written false so if you remove this line await raffle.enterRaffle({ value: raffleEntranceFee }) it will return following stuff

isOpen  true
timePassed  true
hasPlayer  false
hasBalance  false
upkeepNeeded false

for more reference you can check your checkUpkeep function in Raffle.sol file

[cryptocambi]

Need to pay more attention. Thank you for your help

[bayurzxsmtp]

Hello! I noticed that the interval AKA i_interval AKA keepersUpdateInterval passed in the helper-hardhat-config.js file is 30 I am guessing that is 30 seconds.
My first impression was that interval was supposed to be the time it takes for the lottery to run. But it seems like it is actually the time interval it takes for the chainlink keepers AKA Automation Nodes to check out the subscribee(my contract) and perform Upkeep (so I read in a discussion thread).

Is this correct? I think the time is actually too short. Now we are using the Automation, the documentation seems quite different.

I assume from Automation the logic is custom. Most of the original Keepers functions are present in the chainlink automation solidity files.

Is there anything I should watch out for and make corrections.

If you successfully used the automation keepers with the project, I will appreciate a shoutout!!!

[cryptocambi]

Hi,

for the way I understood the interval is the time between one raffle and the next one. It determines the minimum amount of time that needs to pass before a new raffle can be initiated.

When the checkUpkeep function is called, it checks if the interval has elapsed since the last raffle by comparing the current timestamp (block.timestamp) with the value of s_lastTimeStamp. If the difference between the two timestamps is greater than i_interval, it indicates that enough time has passed, and the contract is ready for a new raffle.

The performUpkeep function is then called to initiate the process of selecting a winner and conducting a new raffle. It updates the s_raffleState to "CALCULATING" and proceeds with requesting random words from the VRF coordinator to determine the winner.