Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iam Role are not supported by Tag Editor #241

Open
PChol22 opened this issue Nov 5, 2023 · 0 comments
Open

Iam Role are not supported by Tag Editor #241

PChol22 opened this issue Nov 5, 2023 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@PChol22
Copy link
Member

PChol22 commented Nov 5, 2023

AWS Tag editor does not support IAM roles.
https://docs.aws.amazon.com/ARG/latest/userguide/supported-resources.html

This is a problem for sls-mentor when using the command with the -t option (which allows to specify one or many tags to filter the resources with). In this case, IAM roles are left out of the analysis as they can't be retrieved by the listAllResourcesFromTags function, and are removed when making an intersection in listAllResources

Question 1: is this a bug or a feature ?
-> IMO it's a bug (because IAM Role can have tags so filtering makes sense, we just can't retrieve them using tags), but I'm open to contradiction there.

Question 2: if we try to fix it, what do we do?
A -> do not filter unsupported resources by tags at all (loses a bit the purpose, but easy)
B -> find another way to filter unsupported resources by tags (harder, but real fix)

Open to suggestions and contributions!

@PChol22 PChol22 added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant