-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use of repel algorithm in other packages? #202
Comments
Thanks for the question! Your package looks interesting, and I'm impressed that you're successfully using the The license gives permission for any developer to copy code from ggrepel. There's no need to ask me for permission. Feel free to decide for yourself whether you'd like to copy the code and modify it, or if you'd like to add ggrepel as a dependency. If you want to avoid waiting for me, then the fastest way forward is to copy the code. This approach also gives you ultimate freedom to customize absolutely everything exactly as you want for your particular application. If you prefer to add ggrepel as a dependency, then this might take some time. I would need to upload a new release of ggrepel on CRAN where the If you think that exporting
|
Just a follow-up on this: What I did now was to copy the C++ function and add it to my own package latticetools, from where it is exported. That means in this package, |
@m-jahn Thank you for the kind note! I think copying the code is a fine solution, and gives you freedom to change everything. 👍 |
Great! That said, are you @slowkow as the |
@m-jahn I would be very happy to merge a PR that exports a usable function, but I don't have time right now to write the PR by myself or to test it extensively. If you decide to do this, please do add yourself as an author to the DESCRIPTION file, and add a new item in the NEWS.md file to summarize the change. I think the ideal PR might also include a new documentation page that shows code examples for how developers might use the exported function. |
Thanks @slowkow, I think I will give it a try. |
As an FYI, there is this package that may be of interest to you @m-jahn and @aravind-j https://github.com/hms-dbmi/repel |
I am developing a
ggplot2
extension (gglyph
) and would like to use the repel algorithm fromggrepel
. I am able to get desired results even though I am trying to repel polygon grobs instead of text grobs.Are you still considering exporting
ggrepel:::repel_boxes2()
? or can I copy the necessary code in my package with attribution as in the case of metacoder and as discussed in #88 ?The text was updated successfully, but these errors were encountered: