Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for linking to GitHub comments #91

Open
sloria opened this issue Sep 16, 2019 · 3 comments
Open

Add support for linking to GitHub comments #91

sloria opened this issue Sep 16, 2019 · 3 comments

Comments

@sloria
Copy link
Owner

sloria commented Sep 16, 2019

No description provided.

@webknjaz
Copy link

webknjaz commented Jan 23, 2024

Would the syntax be something like

:issue:`123#issuecomment-12345`

?

Or does it need to be a new RST role?

@webknjaz
Copy link

FWIW here's what I do in my projects typically —https://github.com/aio-libs/aiohttp/blob/a379e63/docs/conf.py#L158-L164 (pending replacement with this extension). I have a generic :gh: role as a stop gap for anything not covered by the specific ones like :pr: or :issue:.

@sloria
Copy link
Owner Author

sloria commented Jan 23, 2024

I like the proposed syntax since it would support any hash fragment within an issue or PR 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants