-
Notifications
You must be signed in to change notification settings - Fork 838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async client uses blocking call when uploading file with v2 #1496
Labels
area:async
bug
M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented
Version: 3x
web-client
Milestone
Comments
16 tasks
seratch
added
bug
M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented
web-client
Version: 3x
area:async
and removed
untriaged
labels
May 13, 2024
Hi @tkdrob, thanks for reporting this issue. You're right that this should be improved, but as you can see here, the source file is auto-generated. Therefore, modifying the code like you did at #1497 does not work. I will come up with a new pull request to make similar changes that are compatible with the codegen. |
seratch
added a commit
to seratch/python-slack-sdk
that referenced
this issue
May 16, 2024
16 tasks
seratch
added a commit
that referenced
this issue
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:async
bug
M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented
Version: 3x
web-client
This project is used to support the Slack integration for the Home-Assistant project. Home-Assistant uses a single event loop and prevents any calls in the event loop that are blocking.
The Slack SDK version
3.27.1
Python runtime version
3.12.3
OS info
ProductName: macOS
ProductVersion: 14.4.1
BuildVersion: 23E224
Steps to reproduce:
Check out the pr below for context. We would still use upload v1 until the upload can be fully async.
home-assistant/core#116868
Expected result:
The files should ideally be uploaded in an asynchronous manner both for local files and remote urls using
aiohttp
with theClientSession
object give byAsyncBaseClient.session
.Actual result:
The call to
putrequest
would block the event loop and so it cannot move forward.logs:
The text was updated successfully, but these errors were encountered: