-
Notifications
You must be signed in to change notification settings - Fork 838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable historical_data_enabled in SQLAlchemyInstallationStore / SQLite3InstallationStore #1133
Comments
I did it by calling |
Hi @olestourko, thanks for taking the time to write in here! Indeed, the We're open to the idea of adding the feature in the future but it won't be a short-term priority. If you operate production-grade apps, we recommend having all the installation history data for safety and for easier troubleshooting. To disable historical data management right now, please go with your workaround or implement your own |
I'm migrating from
FileInstallationStore
toSQLAlchemyInstallationStore
for storing credentials and don't want to store old installation records when the app is reinstalled.With
FileInstallationStore
I used the flag for disabling historical records to do this. I'm trying to accomplish the same withSQLAlchemyInstallationStore
and the SDK does check if a previous installation for the team exists and updates the existing record if so. However, in determining if a previous installation exists it requires an exact match oninstalled_at
:python-slack-sdk/slack_sdk/oauth/installation_store/sqlalchemy/__init__.py
Line 148 in cf22599
This guarantees that reinstalls always create a new record instead of updating the existing one since the install dates will always be different. I'm wondering if this is a bug or if its expected behaviour and there's some other way we're supposed to handle reinstalls.
The text was updated successfully, but these errors were encountered: