Skip to content

Commit 6ca12d0

Browse files
build: enable tests that are no longer unstable (#1617)
1 parent 4dfcbf5 commit 6ca12d0

File tree

3 files changed

+0
-10
lines changed

3 files changed

+0
-10
lines changed

.github/workflows/ci-build.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ jobs:
2626
- "pypy3.10"
2727
env:
2828
CI_LARGE_SOCKET_MODE_PAYLOAD_TESTING_DISABLED: "1"
29-
CI_UNSTABLE_TESTS_SKIP_ENABLED: "1"
3029
FORCE_COLOR: "1"
3130
steps:
3231
- uses: actions/checkout@v4

tests/helpers.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,3 @@ def remove_os_env_temporarily() -> dict:
2424

2525
def restore_os_env(old_env: dict) -> None:
2626
os.environ.update(old_env)
27-
28-
29-
def is_ci_unstable_test_skip_enabled() -> bool:
30-
return os.environ.get("CI_UNSTABLE_TESTS_SKIP_ENABLED") == "1"

tests/slack_sdk/socket_mode/test_interactions_websocket_client.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111

1212
from slack_sdk import WebClient
1313
from slack_sdk.socket_mode.websocket_client import SocketModeClient
14-
from tests.helpers import is_ci_unstable_test_skip_enabled
1514
from tests.slack_sdk.socket_mode.mock_socket_mode_server import (
1615
start_socket_mode_server,
1716
socket_mode_envelopes,
@@ -90,10 +89,6 @@ def socket_mode_request_handler(client: BaseSocketModeClient, request: SocketMod
9089
client.close()
9190

9291
def test_send_message_while_disconnection(self):
93-
if is_ci_unstable_test_skip_enabled():
94-
# this test tends to fail on the GitHub Actions platform
95-
return
96-
9792
try:
9893
client = SocketModeClient(
9994
app_token="xapp-A111-222-xyz",

0 commit comments

Comments
 (0)