Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict between AWS CLI and Sphinx dependencies causing doc build failure (docutils version mismatch) #4478

Open
zpoint opened this issue Dec 18, 2024 · 0 comments

Comments

@zpoint
Copy link
Collaborator

zpoint commented Dec 18, 2024

bug reproduce:

# activate conda
cd docs
pip install -r requirements-docs.txt
cd ..
pip install -e .[all]
cd docs
./build.sh

output:

    'meta': (nodes.meta, 'docutils.nodes.meta'),  # type: ignore[attr-defined]
AttributeError: module 'docutils.nodes' has no attribute 'meta'
make: *** [html] Error 1

Its because awscli>=1.27.10 requires docutils<0.17,>=0.10, while our doc build use sphinx==7.1.2 which requires docutils<0.21,>=0.18.1
pip install -e .[all] gets docutils==0.16 from awscli>=1.27.10
pip install -r requirements-docs.txt gets docutils==0.19 from sphinx==7.1.2
The doc build only works with docutils==0.19

Profile:

pip install git+https://github.com/aws/aws-cli.git@v2  18.50s user 10.30s system 57% cpu 49.714 total
pip install 'awscli>=1.27.10'  1.36s user 0.56s system 77% cpu 2.468 total

30 seconds slower install from source

They are not publishing this to pypi, if we want to install it we should install from source

Closed PR: #4474

Version & Commit info:

  • sky -v: PLEASE_FILL_IN
  • sky -c: PLEASE_FILL_IN
@Michaelvll Michaelvll added the OSS label Dec 19, 2024 — with Linear
@Michaelvll Michaelvll removed the OSS label Dec 19, 2024
@Michaelvll Michaelvll added the OSS label Dec 19, 2024 — with Linear
@Michaelvll Michaelvll removed the OSS label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants