Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload of large files is never chunked #168

Open
Ph0tonic opened this issue Jul 31, 2023 · 3 comments
Open

Upload of large files is never chunked #168

Ph0tonic opened this issue Jul 31, 2023 · 3 comments

Comments

@Ph0tonic
Copy link

Hi,

When uploading large files like 100 Mo or bigger ones (1 To), these are never chunked.
I would expect the client to offer a way to enforce chunk encoding or automatically chunks large files.
An alternative to the current method which tries to always avoid chunk encoding would be to use chunk encoding when a chunk_size is provided (see #167).
What we could also do is add an extra flag to enforce chunks.
Thanks,

@skshetry
Copy link
Owner

skshetry commented Aug 1, 2023

Hi @Ph0tonic. Could you please elaborate why you need to chunk? What issues do you run into?

The reason why we don't prefer chunked-encoding is that not a lot of servers support chunked encoding in PUT. This is mostly older servers, but we do bump into them time to time.
See iterative/dvc#4796.

@Ph0tonic
Copy link
Author

Ph0tonic commented Aug 3, 2023

Hi,
So I will have to test it again, but we had some trouble going through a proxy with non-chunked encoding. I understand your point of view and I will check again with our new set-up to see if we still have this issue.
Thanks for your answer

@skshetry
Copy link
Owner

Any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants