Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schain object by default #563

Merged
merged 6 commits into from
Sep 4, 2024
Merged

Schain object by default #563

merged 6 commits into from
Sep 4, 2024

Conversation

badrogger
Copy link
Collaborator

Changes

  • Use SchainStruct by default.

Testing

  • Fixed unit tests.

Performance

  • No performance related changes were introduced.

@badrogger badrogger marked this pull request as ready for review September 3, 2024 19:09
@codecov Codecov
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.14%. Comparing base (2531b0f) to head (903ec80).

Files with missing lines Patch % Lines
skale/utils/web3_utils.py 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             beta     #563   +/-   ##
=======================================
  Coverage   91.14%   91.14%           
=======================================
  Files          65       65           
  Lines        2474     2474           
=======================================
  Hits         2255     2255           
  Misses        219      219

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dmytrotkk
dmytrotkk approved these changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@dmytrotkk dmytrotkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

majestic ✨

@badrogger badrogger merged commit e39bd79 into beta Sep 4, 2024
6 checks passed
@badrogger badrogger deleted the schain-object-by-default branch September 4, 2024 16:47
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dmytrotkk dmytrotkk dmytrotkk approved these changes

@kladkogex kladkogex Awaiting requested review from kladkogex kladkogex is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@badrogger @dmytrotkk