Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Microsoft.Azure.Management.WebSites or constrain dependency version #371

Open
ohadschn opened this issue Jun 8, 2020 · 0 comments

Comments

@ohadschn
Copy link
Contributor

ohadschn commented Jun 8, 2020

letsencrypt.azure.core lists Microsoft.Azure.Management.WebSites as a dependency with the condition: >= 2.0.1

However upgrading Microsoft.Azure.Management.WebSites to version 3.0.0 results in:

Error during Request or install certificate System.MissingMethodException: Method not found: 'Void Microsoft.Azure.Management.WebSites.Models.Certificate..ctor(System.String, System.String, System.String, System.String, System.String, System.String, System.Collections.Generic.IDictionary`2<System.String,System.String>, System.String, System.String, System.Collections.Generic.IList`1<System.String>, Byte[], System.String, System.String, System.String, System.Nullable`1<System.DateTime>, System.Nullable`1<System.DateTime>, System.String, System.Nullable`1<Boolean>, Byte[], System.String, Microsoft.Azure.Management.WebSites.Models.HostingEnvironmentProfile, System.String, System.String, System.Nullable`1<Microsoft.Azure.Management.WebSites.Models.KeyVaultSecretStatus>, System.String)'.
   at LetsEncrypt.Azure.Core.Services.WebAppCertificateService.<Install>d__3.MoveNext()
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder.Start[TStateMachine](TStateMachine& stateMachine)
   at LetsEncrypt.Azure.Core.Services.WebAppCertificateService.Install(ICertificateInstallModel model)
   at LetsEncrypt.Azure.Core.CertificateManager.<RequestAndInstallInternalAsync>d__15.MoveNext()

Looking at the ctor, looks like 3.0.0 indeed broke backwards compatibility (added an additional canonicalName param to the ctor). So letsencrypt.azure.core should be either upgraded, or specified with the correct dependency, namely >= 2.0.1 && < 3.0.0

@ohadschn ohadschn changed the title Update Microsoft.Azure.Management.WebSites or lock version Update Microsoft.Azure.Management.WebSites or constrain dependency version Jun 8, 2020
ohadschn added a commit to ohadschn/letsencrypt-webapp-renewer that referenced this issue Jun 8, 2020
ohadschn added a commit to ohadschn/letsencrypt-webapp-renewer that referenced this issue Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant