From db9e8d0d1aa580e0c1cdf75dc4017a31e4c6dafb Mon Sep 17 00:00:00 2001 From: Allen Wittenauer Date: Sat, 5 Aug 2023 11:52:19 -0700 Subject: [PATCH] Don't assume that wikidata label applies to every other wikipedia system. --- wptools/page.py | 8 +++++--- wptools/wikidata.py | 13 ++++++++----- 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/wptools/page.py b/wptools/page.py index ea86cef..1a5c159 100644 --- a/wptools/page.py +++ b/wptools/page.py @@ -504,12 +504,14 @@ def get(self, show=True, proxy=None, timeout=0): self.flags['defer_imageinfo'] = True self.get_wikidata(False, proxy, timeout) - self.get_query(False, proxy, timeout) - self.get_parse(False, proxy, timeout) + if self.params.get('title'): + self.get_query(False, proxy, timeout) + self.get_parse(False, proxy, timeout) self.flags['defer_imageinfo'] = False - self.get_restbase('/page/summary/', False, proxy, timeout) + if self.params.get('title'): + self.get_restbase('/page/summary/', False, proxy, timeout) if show and not self.flags.get('silent'): self.show() diff --git a/wptools/wikidata.py b/wptools/wikidata.py index 25eeca7..34bb71c 100644 --- a/wptools/wikidata.py +++ b/wptools/wikidata.py @@ -138,7 +138,7 @@ def _set_title(self, item): """ title = None lang = self.params['lang'] - label = self.data['label'] + # label = self.data['label'] if item.get('sitelinks'): for link in item['sitelinks']: @@ -146,11 +146,14 @@ def _set_title(self, item): title = item['sitelinks'][link]['title'] self.data['title'] = title.replace(' ', '_') - if not self.data.get('title') and label: - self.data['title'] = label.replace(' ', '_') + # aw - this leads to completely incorrect data because + # it assumes that everything is in en.wikipedia later + # + # if not self.data.get('title') and label: + # self.data['title'] = label.replace(' ', '_') - if self.data.get('title') and not self.params.get('title'): - self.params['title'] = self.data['title'] + # if self.data.get('title') and not self.params.get('title'): + # self.params['title'] = self.data['title'] def _set_wikidata(self): """