Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub action test for --debug #1962

Open
soulgalore opened this issue Jun 20, 2023 · 1 comment
Open

Add GitHub action test for --debug #1962

soulgalore opened this issue Jun 20, 2023 · 1 comment

Comments

@soulgalore
Copy link
Member

We are missing a test case where we use --debug. To do that we need to either interact with the browser or just kill after some time (and check the log that everything is ok until everything is closed). It would be cool if we can come up with a pattern we can reuse in some other test cases.

@gmierz
Copy link
Collaborator

gmierz commented Jun 21, 2023

@soulgalore we could split this into two different kinds of tests. The first kind could be only for checking to make sure that there are no parser error raised when --debug is passed with some combinations of other options (e.g. pass with --android.enabled to ensure a parser error is raised). The second kind can be to make sure that the browser enters debug mode which might be harder to figure out how to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants