Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features: Icon should conform to container shape #442

Open
AlexGStapleton opened this issue Mar 22, 2017 · 2 comments
Open

Features: Icon should conform to container shape #442

AlexGStapleton opened this issue Mar 22, 2017 · 2 comments

Comments

@AlexGStapleton
Copy link
Member

The icon shouldn't exceed the container and should be clipped if it does. Think of a clipping mask in Photoshop.

Example:

How it should look:

@gregpriday
Copy link
Member

As far as I remember, we're using iconic fonts for the background of these containers, so there's no support for clipping at the moment. We could look at using SVG, or just adding a special case for the circle container.

@AlexGStapleton
Copy link
Member Author

AlexGStapleton commented Mar 22, 2017

A font is being used for the container background, yes. I'm unsure what the font is though.

I think the circle container would be the ideal short term solution as it would allow users to completely replace the Circle Icon widget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants