[Bug] App not quitting correctly on macOS

[mtdvlpr]

The warning that occurs when a meeting is running is great, but having to close it twice when no meeting is running doesn’t make sense to me. I recorded videos that will show what I think you already know. When you close it like you would Excel, the window goes away but M3 is still running. You can’t do anything with it at this point except quit again. If you don’t, it is taking system resources and most people don’t notice that it’s still running. Just a suggestion, you guys do great work!

Meeting running, 3 cmd-quit
https://github.com/user-attachments/assets/bae96d47-d6c8-4732-9b80-6fda3a27860e

Meeting not running, 2 cmd quit
https://github.com/user-attachments/assets/30d7b903-180b-4c69-8836-53a5cb17e895

Typical close of Excel, only 1 cmd quit
https://github.com/user-attachments/assets/b61edd49-d6c6-4a4e-b234-dc09adcc2f25

Thanks,
Mark Cillis

Originally posted by @skimark1 in #3222 (comment)

[mtdvlpr]

Correct behavior:

Windows and Linux

• Click on close main window button
  • Meeting has started or media is showing?
    • No: Quit app
    • Yes: First click?
      • No: It's the second click, quit app
      • Yes: Show warning

macOS

• Click on close main window button
  • Meeting has started or media is showing?
    • No: Close all windows but do not quit app
    • Yes: First click?
      • No: It's the second click, close all windows but do not quit app
      • Yes: Show warning
• When windows are closed but app is running, clicking the app icon should activate the app and open the main window again.
• Cmd-Q
  • Meeting has started or media is showing?
    • No: Close all windows and quit app
    • Yes: First click?
      • No: It's the second click, quit app
      • Yes: Show warning

[mtdvlpr]

@skimark1, could you please install the test version below and perform the different scenarios again. I've added some debug statements that should give me a better clue of what's going on.

https://github.com/sircharlo/meeting-media-manager/actions/runs/12843701711

[skimark1]

I tested on Intel Mac & M2 MBA and got the same results in both places. Still requires 2-3 cmd quits to close M3. Interestingly, I had to use the terminal commands to be able to open M3 on the MBA silicon Mac. Thanks, Mark Cillis ***@***.***

…

On Jan 18, 2025, at 4:46 AM, Manoah Tervoort ***@***.***> wrote: @skimark1 <https://github.com/skimark1>, could you please install the test version below and perform the different scenarios again. I've added some debug statements that should give me a better clue of what's going on. https://github.com/sircharlo/meeting-media-manager/actions/runs/12843590715 — Reply to this email directly, view it on GitHub <#3967 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A6S45XCJ7UBPWA4KNQHCSML2LI5I5AVCNFSM6AAAAABVNIJTTOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJZGY4DGNRRGY>. You are receiving this because you were mentioned.

[mtdvlpr]

That's expected behavior. I hadn't changed any of the logic yet. Just added debug statements. The in-between test versions are not signed and notarized, so you indeed need the terminal commands for it.

I've now improved the logic, so below version might fix it. Let me know!

https://github.com/sircharlo/meeting-media-manager/actions/runs/12845896447

[skimark1]

Same behavior, 3 cmd quits if media running, 2 if only meeting Thanks, Mark Cillis ***@***.***

…

On Jan 18, 2025, at 10:25 AM, Manoah Tervoort ***@***.***> wrote: That's expected behavior. I hadn't changed any of the logic yet. Just added debug statements. The in-between test versions are not signed and notarized, so you indeed need the terminal commands for it. I've now improved the logic, so below version might fix it. Let me know! https://github.com/sircharlo/meeting-media-manager/actions/runs/12845896447 — Reply to this email directly, view it on GitHub <#3967 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A6S45XASVOTCDEIZ6P3TYGL2LKE67AVCNFSM6AAAAABVNIJTTOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJZG44TQOJYHE>. You are receiving this because you were mentioned.

[mtdvlpr]

Okay, thank you for your help! I'm pretty sure I fixed it. Please test below version:

https://github.com/sircharlo/meeting-media-manager/actions/runs/12851742920

[skimark1]

The version for Intel closes like it should with the exception of when the background music is playing you don’t get a warning that the meeting is running. When playing media for the meeting the warning does pop up. Not a deal breaker, just glad to get rid of the extra close cmd. The Silicon version is damaged and won’t open. I ran the terminal commands multiple times on multiple attempts to install it and get the damaged file warning every time. Thanks, Mark Cillis ***@***.***

…

On Jan 19, 2025, at 1:18 AM, Manoah Tervoort ***@***.***> wrote: Okay, thank you for your help! I'm pretty sure I fixed it. Please test below version: https://github.com/sircharlo/meeting-media-manager/actions/runs/12851742920 — Reply to this email directly, view it on GitHub <#3967 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A6S45XHFRMSL4UMWQJHUNSD2LNNU5AVCNFSM6AAAAABVNIJTTOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBQG42TGMRWGY>. You are receiving this because you were mentioned.

[mtdvlpr]

Alright, thanks for helping me figure this is out! I'll consider this fixed. If you want to be certain that it also works for the Silicon version, you can try below version. Below version is identical to an official release, so should not require the terminal commands.

https://github.com/sircharlo/meeting-media-manager/actions/runs/12855709650

[mtdvlpr]

In the next release, the warning will also popup when background music is playing.

[skimark1]

Works perfectly! Great work and thank you so much for fixing that problem. You guys rock! Thanks, Mark Cillis ***@***.***

…

On Jan 19, 2025, at 10:41 AM, Manoah Tervoort ***@***.***> wrote: Alright, thanks for helping me figure this is out! I'll consider this fixed. If you want to be certain that it also works for the Silicon version, you can try below version. Below version is identical to an official release, so should not require the terminal commands. https://github.com/sircharlo/meeting-media-manager/actions/runs/12855709650 — Reply to this email directly, view it on GitHub <#3967 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A6S45XD4RAVTLD4TJ2Z7RD32LPPWLAVCNFSM6AAAAABVNIJTTOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBQHE2TMNBRGQ>. You are receiving this because you were mentioned.