Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assignment of an array element counts as a read #307

Open
sirbrillig opened this issue Aug 5, 2023 · 0 comments
Open

Assignment of an array element counts as a read #307

sirbrillig opened this issue Aug 5, 2023 · 0 comments
Labels

Comments

@sirbrillig
Copy link
Owner

sirbrillig commented Aug 5, 2023

Discovered in #305, an assignment of one element of an array does not get recorded as a write to that variable.

$foo = &$bar;
$foo['key'] = 1; // This counts as a "read" of $foo when it should be a "write".

I think in most cases this ends up not being an issue since clearly all the tests are passing but it could be the source of subtle bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant