-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unused arguments should not be reported for magic methods #132
Comments
Any fix for this should probably also cover the magic (global) |
Oh, great point. Thanks! |
Just noting I recently ran into this again. Utils is getting close to the 1.0.0 release, so maybe we should leave it until that's available ? |
Oh, thanks. I had forgotten about this issue. I'm stretched pretty thin right now but I'll see if I can write up a quick patch to ignore unused params in these magic methods, but if not we'll just wait for the Utils functions. |
PHP magic methods have a method signature check.
While in most cases it wouldn't make sense not to use the declared/passed parameters, most notably with
__call()
and__callStatic()
there can be situations in which not all parameters are used, like when it is known that the methods which will be called will not take arguments.Currently this standard will throw a
Unused function parameter $name. (VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable)
warning in this situation, but the offending parameter can not be removed as otherwise PHP generates a fatal error.Refs:
In case you're interested,
PHPCSUtils
contains some utility methods which could be used to fix this: https://github.com/PHPCSStandards/PHPCSUtils/blob/a9ee9e0afffca398df6f997b44628440aa838d41/PHPCSUtils/Utils/FunctionDeclarations.php#L844-L881The text was updated successfully, but these errors were encountered: