Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Separating Shape buttons #170

Open
AMISH-KHAN opened this issue May 20, 2024 · 12 comments
Open

[FEAT] Separating Shape buttons #170

AMISH-KHAN opened this issue May 20, 2024 · 12 comments
Assignees
Labels
enhancement New feature or request gssoc level1

Comments

@AMISH-KHAN
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Currently the Shape button has circle rectangle and triangle shape combined.

Screenshot 2024-05-20 170329

Describe the solution you'd like

It would be good if we had separate Buttons.

Additional context

Please assign this issue to me under Gssoc

@singodiyashubham87
Copy link
Owner

@AMISH-KHAN You are already assigned an issue, wait till that issue is closed. Then I'll assign you this issue if none has asked to work upon till then.

@AMISH-KHAN
Copy link
Contributor Author

Cool

@AMISH-KHAN
Copy link
Contributor Author

@singodiyashubham87 I think now I don't have any assigned issue so please assign this one to me

@singodiyashubham87
Copy link
Owner

@AMISH-KHAN Assigned!
Best of Luck!

@AMISH-KHAN
Copy link
Contributor Author

hey @singodiyashubham87 can you please make it level 2 because I will be implementing something like we have for pencil i.e dropdown menu

@Mahimatestgithub
Copy link

I want to work in this issue. Please assign me this task.

@AMISH-KHAN
Copy link
Contributor Author

AMISH-KHAN commented May 23, 2024

@singodiyashubham87 this is what I've made

shapes.mp4

I think the current website lacks the feature of getting back to the pen after selecting a shape.
this is from the current website.

backtoopen.mp4

do you want me to raise an issue about it??

@singodiyashubham87
Copy link
Owner

@AMISH-KHAN There is already an issue regarding the pen bug. #188
& What you have made is good, you can create a PR now.

@singodiyashubham87
Copy link
Owner

@AMISH-KHAN As of level2, The issues are labelled considering many factors like approx. time, difficulty & priority.
& considering all those this issue was of easy type & therefore can't make it a level2 issue.
Hope you understand :)

@AMISH-KHAN
Copy link
Contributor Author

Cool I will do it

@AMISH-KHAN
Copy link
Contributor Author

@AMISH-KHAN As of level2, The issues are labelled considering many factors like approx. time, difficulty & priority.
& considering all those this issue was of easy type & therefore can't make it a level2 issue.
Hope you understand :)

No problem 😁

AMISH-KHAN added a commit to AMISH-KHAN/Draw-it-out that referenced this issue May 25, 2024
@AMISH-KHAN
Copy link
Contributor Author

@singodiyashubham87 please check pr #210

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc level1
Projects
None yet
Development

No branches or pull requests

3 participants