Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add TS 5.0 options #573

Merged

Conversation

shun-shobon
Copy link
Contributor

Hi. I have added an option to tsconfig.json that was added by the recently released TypeScript 5.0.

Ref: https://devblogs.microsoft.com/typescript/announcing-typescript-5-0

@sindresorhus
Copy link
Owner

Thanks for working on this. Can you double check that you covered all the changes for 5.0?

Co-authored-by: Sindre Sorhus <[email protected]>
@shun-shobon
Copy link
Contributor Author

I forgot to check this section here. I will fix it.
https://devblogs.microsoft.com/typescript/announcing-typescript-5-0/#deprecations-and-default-changes

@shun-shobon
Copy link
Contributor Author

@sindresorhus
I checked it. Can you review this?

@kidonng
Copy link
Contributor

kidonng commented Mar 17, 2023

@shun-shobon
Copy link
Contributor Author

@kidonng

I have tested and it appears that TS5.0.2 does not support ES2023.

image

@kidonng
Copy link
Contributor

kidonng commented Mar 17, 2023

That's weird, because there are definitions for ES2023: https://github.com/microsoft/TypeScript/blob/v5.0.2/lib/lib.es2023.d.ts
Some TS internals might be outdated I guess.

@shun-shobon
Copy link
Contributor Author

shun-shobon commented Mar 17, 2023

When I was running TypeScript, it seems that Node10 was added to the moduleResolution. There's a lot I don't understand since the documentation hasn't been updated yet...

microsoft/TypeScript#51901

@sindresorhus sindresorhus merged commit aafc938 into sindresorhus:main Mar 17, 2023
7 checks passed
@shun-shobon shun-shobon deleted the feature/add-ts-5.0-options branch March 17, 2023 08:10
@michalbundyra
Copy link

@sindresorhus As it is merged, can we expect a release soon? Or something else needs to be done to provide support for TypeScript 5.0? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants