Meta tweaks #11

tommy-mitchell · 2023-03-20T16:31:18Z

Closes #6. Figured I'd go ahead and do this if I had to fork the repo anyway for #10.

tommy-mitchell · 2023-03-20T16:34:59Z

CI fails on this and #12 for Node 12 due to meow:

file:///home/runner/work/trim-newlines/trim-newlines/node_modules/xo/node_modules/meow/index.js:85
			flag.default = flag.default ?? [];
			                             ^

SyntaxError: Unexpected token '?'

sindresorhus · 2023-03-20T17:39:08Z

Just a note for the future: The PR title is not very useful. This PR contains breaking changes and the title should have reflected that. 👍

sindresorhus · 2023-03-20T17:40:08Z

index.d.ts

+```js
+import trimNewlines from 'trim-newlines';
+
+trimNewlines.end('\n🦄\r\n');


I missed this too, but you forgot to update the docs (already done in main branch now).

tommy-mitchell added 2 commits March 20, 2023 11:08

chore: update dependencies

7daa273

chore: switch to named exports

cf424cc

tommy-mitchell mentioned this pull request Mar 20, 2023

Type improvements #12

Merged

tommy-mitchell mentioned this pull request Mar 20, 2023

Improve example for trimNewlines #10

Merged

Update main.yml

26baf1d

sindresorhus merged commit 40cd948 into sindresorhus:main Mar 20, 2023
3 checks passed

sindresorhus reviewed Mar 20, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Meta tweaks #11

Meta tweaks #11

tommy-mitchell commented Mar 20, 2023 •

edited

tommy-mitchell commented Mar 20, 2023

sindresorhus commented Mar 20, 2023 •

edited

sindresorhus Mar 20, 2023

Meta tweaks #11

Meta tweaks #11

Conversation

tommy-mitchell commented Mar 20, 2023 • edited

tommy-mitchell commented Mar 20, 2023

sindresorhus commented Mar 20, 2023 • edited

sindresorhus Mar 20, 2023

Choose a reason for hiding this comment

tommy-mitchell commented Mar 20, 2023 •

edited

sindresorhus commented Mar 20, 2023 •

edited