Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

darwin arguments need to come before url #331

Closed
mshanemc opened this issue Jan 5, 2024 · 0 comments · Fixed by #332
Closed

darwin arguments need to come before url #331

mshanemc opened this issue Jan 5, 2024 · 0 comments · Fixed by #332

Comments

@mshanemc
Copy link
Contributor

mshanemc commented Jan 5, 2024

use case where I found this:

open('https://google.com', { app: { name: apps['browserPrivate'] }, newInstance: true }

results in cliArguments being

--new,-a,google chrome,https://google.com, --args,--incognito

on mac, the order or arguments matters. replication

open -na "google chrome" --args --incognito https://google.com => incognito
open -na "google chrome" https://google.com --args --incognito => not incognito

I'm gonna speculate some of the other open issues may also result from the args being in the wrong order.

I made a PR. This worked for my use case/machine #332

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant