New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v9 fails within VSCode extension as import.meta.url is null #324
Comments
Note, I should say that I'm testing on Windows. That is, "file:" urls not opening seems to be a function of Windows behaviour. If you use a Windows command line and just type "Start http://www.google.com" it works, but if you type "start file:///c%3a/somewhere" it doesn't. Note that "start file:///c:/somewhere" DOES work, however, that's not what you get when you URL encode a filename. Anyway, workaround is to explicitly specify "app: browser", but that doesn't work on version 8, "browser" was only introduced in version 9. The reference to "import.meta.url" in version 9 then fails when run inside VSCode for some reason. |
Also, fragments don't work with file: URLs on Windows without using a specific app (so |
I'm by no means a node expert, so I don't know whether import.meta.url being null is unexpected or not.
Trying to use this within a VSCode extension. The "import" of open fails, with an error on the line:
Error is:
I don't know what is unusual about how vscode is loading modules. Not had any issues previously.
The v8.4.2 works in this regard. However, with that version you don't appear to be able to open "file:" urls without explicitly specifying that it should use a browser (using
app: { name: apps.chrome}
for example). However, that version doesn't have the ability to use the default browser.The text was updated successfully, but these errors were encountered: