-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite in Ink #83
Rewrite in Ink #83
Conversation
|
When searching, if you write a word, you should be able to press option+left-arrow to go back to the start, or option+right-arrow to go to the end. This worked before this PR. Pressing Option+Delete when at the end of the search line, should clear the search text too. |
In case you are interested in making some improvements over the old version too:
|
@jopemachine Still interested in finishing this? |
Yes, I'm definitely interested in this issue and other current issues of fkill-cli. So, there are some issues to look into.
: For implementing these features, I think updating
: I think I can look into it when available. |
Check the output whether it's ESM or CJS. You may have set the |
Just add a TODO comment about fixing it when Ink properly supports ESM. |
I think we can live without these for now. We'll just open new issues about fixing it at some point. |
Yes, that should ideally work. Not sure when it broke. |
I'm not sure what is the Babel comment you mentioned, although the output is ESM.
I think this is not required since
I copy and pasted the above two repositories' source code and patched the
I'm not sure about the cause but I checked this feature worked normally in 5.2.0, but broke in 6.0.0, maybe inquirer 7's default behavior change? I added the feature since I don't see port-searching related code. I'd appreciate your letting me know if there's anything else I could help. |
Can you fix the merge conflict? |
"execa": "^5.1.1", | ||
"get-port": "^6.0.0", | ||
"noop-process": "^5.0.0", | ||
"process-exists": "^4.1.0", | ||
"xo": "^0.45.0" | ||
"xo": "^0.48.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrade to latest of all dependencies.
Write If you do the same, but hold Command instead Option, it adds a |
Bump |
@sindresorhus |
No worries. But since there's no definite date of that happening, I prefer to close this for now to keep my PR queue clean. Feel free to submit a new pull request if/when you have time to finish this. |
Fixes #34.
It seems working now but I think I need to a little more time to look into more error handling logics and test codes and lint (WIP).
Thank you for all your efforts for maintaining awesome libs.