Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove accessibility permission check and option #179

Closed

Conversation

kentbetita
Copy link
Contributor

@kentbetita kentbetita commented Feb 24, 2024

Description

The accessibility permission is no longer needed to get the url of the active browser tab. As a result, the accessibilityPermission option and the associated checks for process/application trust have been removed from the codebase.

Changes

  • The accessibilityPermission configuration option has been completely removed.
  • The check to verify if the process/application is trusted for accessibility access has been excised.

Demo

2024-02-24.10-08-59.mp4

Related

@kentbetita
Copy link
Contributor Author

kentbetita commented Feb 24, 2024

Hey @sindresorhus,

Oops, I dropped the ball on #177. I was coding away in VS Code and forgot it already had the accessibility permissions set up, so I got tricked into thinking everything was working perfectly with the accessibilityPermission option. But then, when I ran the app live, it was still asking for accessibility permission – my bad!

I doubled down on the problem for issue #179 (which was #178 before), and after some serious digging, I found out we can actually still snag the url property without needing those accessibility permissions at all. Hence, we actually don't really need the accessibility permission check anymore.

I'm really sorry for the oversight. Thanks for your patience and understanding. Won't happen again! 🙏🏻

@kentbetita
Copy link
Contributor Author

Hey @sindresorhus, just giving you a little nudge! 😄 Hope you're doing great!

@sindresorhus
Copy link
Owner

I'm pretty sure it's required, but it may only be required for sandboxed apps.

@kentbetita
Copy link
Contributor Author

I think I've found a solution that works for both cases now. Will close this one out and submit another PR!

@kentbetita kentbetita closed this Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants