Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add accessibilityPermission option #177

Merged

Conversation

kentbetita
Copy link
Contributor

@kentbetita kentbetita commented Feb 20, 2024

Why

There has been issues with macOS users regarding accessibility permission. The accessibility permission is needed in order to get the complete window title. Apparently, the screenRecordingPermission already handles this concern so there is no need for the accessibility permission. To fix this we could just update the if condition but just in case, this PR just adds a new option accessibilityPermission.

  • accessibilityPermission: false - disables the accessibility permission prompt.

Changes

  • Add a accessibilityPermission option.
  • Skip the accessibility permission check if true.

Related

@sindresorhus
Copy link
Owner

If it's actually not needed, I prefer to just remove it.

@kentbetita
Copy link
Contributor Author

Submitted the PR #178 for your review @sindresorhus. Thanks.

@kentbetita kentbetita closed this Feb 22, 2024
@sindresorhus sindresorhus reopened this Feb 22, 2024
index.d.ts Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
Sources/ActiveWinCLI/main.swift Show resolved Hide resolved
@sindresorhus sindresorhus merged commit 0573a54 into sindresorhus:main Feb 23, 2024
0 of 3 checks passed
@kentbetita kentbetita deleted the feat/disable-accessibility-prompt branch February 23, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants