Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache bridge deserialization #138

Open
BeyondiOS opened this issue May 24, 2023 · 1 comment
Open

Cache bridge deserialization #138

BeyondiOS opened this issue May 24, 2023 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@BeyondiOS
Copy link

struct User3: Codable, Defaults.Serializable {
    let name: String
    let age: String
}

extension Defaults.Keys {
    static let user3 = Key<User3>("user3", default: .init(name: "Hello", age: "24"))
}
...
    func test2() {
        print(Defaults[.user3])
        print(Defaults[.user3])
    }
...

The above code will call bridge.deserialize twice. If user3 is an array and there are many attributes of the User3 type, will it affect performance?

Would it be better to cache the data after Defaults[.user3] is executed once?

extension Defaults.Serializable {
	....
	static func toValue(_ anyObject: Any) -> Self? {
		// Return directly if `anyObject` can cast to Value, since it means `Value` is a natively supported type.
		if
			isNativelySupportedType,
			let anyObject = anyObject as? Self
		{
			return anyObject
		} else if let value = bridge.deserialize(anyObject as? Serializable) {
			return value as? Self
		}

		return nil
	}
        ....
@sindresorhus
Copy link
Owner

sindresorhus commented Jun 20, 2023

It can affect performance yes, if the data is large and you're calling it many times in a loop. But in common cases, it should not be a problem. You should not store huge amounts of data in UserDefaults anyway.

I do think we should look into caching the deserialized data using an LRU cache.

Actually, the first thing we could do is to simply cache all calls for 5 seconds. That way, we can make sure that we don't waste time on deserializing things that are called in a loop.

@sindresorhus sindresorhus changed the title If it is a custom type, deserialize will be called every time it is used, will it affect performance? Cache bridge deserialization Jun 20, 2023
@sindresorhus sindresorhus added enhancement New feature or request help wanted Extra attention is needed labels Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants