You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think by introducing a "command type" we can get rid of the need to make callbacks for Commander. We could still keep a "callback command type" so callbacks are still possible (since they are useful) but for all the standard types supported by Commander like motor, pid, scalar we could get rid of those callbacks and just keep an internal table of command letters to command types, and call the commander.motor() function directly.
So the user calls just addMotor('M', &motor); and Commander does the rest internally.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
I think by introducing a "command type" we can get rid of the need to make callbacks for Commander. We could still keep a "callback command type" so callbacks are still possible (since they are useful) but for all the standard types supported by Commander like motor, pid, scalar we could get rid of those callbacks and just keep an internal table of command letters to command types, and call the commander.motor() function directly.
So the user calls just
addMotor('M', &motor);
and Commander does the rest internally.Beta Was this translation helpful? Give feedback.
All reactions