-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React package doesn't support changes to props #226
Comments
From my best guess, it's because of the empty dependency array in SelectionArea |
That was on purpose since the core module doesn't support dynamic option updates. The preact/react component would have to destroy the instance and re-create it. In your case adding a |
What is the problem?
When using the react package, if you have state changes to the props being passed to
SelectionArea
, those changes are not recognized. For example, if you want to use a ref on the container prop, if that container changes, Viselect doesn't recognize these changes.What is the current behavior?
Changing a prop to the
SelectionArea
results in those changes not being recognized.Please provide the steps to reproduce and create a CodeSandbox.
CodeSandbox Link
What is the expected behavior?
Whenever you change a prop, @viselect/react should be updating to use those new props
Your environment:
The text was updated successfully, but these errors were encountered: