-
-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial color not set correctly when pickr parent is not visible. #226
Labels
bug
Something isn't working
discussion
This is a discussion about a change, feature or strongly code-related
Comments
Fixed in 0d445e5, I'll publish a patch version in the next days! |
DEfusion
added a commit
to bandzoogle/pickr
that referenced
this issue
Jul 7, 2020
If the container the pickr is output in is not visible when it is created the position of the movable handles is not shown correctly on opening, this then has the knock-on effect of not setting the color correctly on interaction unless you click on the palette or a swatch first. This change addresses that by ensuring the color is set on the first run of `show` after the picker is made visible. Fixes simonwep#226
DEfusion
added a commit
to bandzoogle/pickr
that referenced
this issue
Jul 7, 2020
If the container the pickr is output in is not visible when it is created the position of the movable handles is not shown correctly on opening, this then has the knock-on effect of not setting the color correctly on interaction unless you click on the palette or a swatch first. This change addresses that by ensuring the color is set on the first run of `show` after the picker is made visible. Fixes simonwep#226
simonwep
added
the
discussion
This is a discussion about a change, feature or strongly code-related
label
Jul 13, 2020
I've published 1.7.2 (Mainly because of a recent serious issue), I'll close this issue as we can work in the PR and the current fix is deployed. Thanks again for your efforts, this should be worked on! :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
discussion
This is a discussion about a change, feature or strongly code-related
What is the current behavior?
If the
container
the pickr is output in is not visible when it is created the position of the movable handles is not shown correctly on opening, this then has the knock-on effect of not setting the color correctly on interaction unless you click on the palette or a swatch first as can be seen in this video: https://share.getcloudapp.com/d5uWDWLBPlease provide the steps to reproduce and create a JSFiddle.
https://jsfiddle.net/5szxbhqk/
What is the expected behavior?
Your environment:
The text was updated successfully, but these errors were encountered: