Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White gap in focus-border #137

Open
simonwep opened this issue Aug 10, 2019 · 2 comments
Open

White gap in focus-border #137

simonwep opened this issue Aug 10, 2019 · 2 comments
Labels
help wanted Extra attention is needed improvement Something could be improved

Comments

@simonwep
Copy link
Owner

Improvement

Currently, if a custom color is applied to .pcr-app there's a white, non-transparent, gap between the focus border and the element (which looks really ugly in a dark envieroment):
image
Unfortunately it's not possible to use any pseudo-elements (most of them are in-use and can't be removed because of stacking-issues).

The current focus-border is made through a double box-shadow where the first one makes the gap:

box-shadow: 0 0 0 1px rgba(white, 0.85), 0 0 0 3px $color;

But this causes a white (or colored) gap.
Already tried to fix it with double-borders, but this would be really difficult since the focus-border is applied to many elements with different pseudo-elements and sizes.

Any help is highly appreciated :)

@simonwep simonwep added help wanted Extra attention is needed improvement Something could be improved labels Aug 10, 2019
@simonwep simonwep pinned this issue Aug 10, 2019
@sdbrannum
Copy link

Is there any reason

border: 1px solid transparent;
box-shadow: 0 0 0 3px $color;

won't work?

@simonwep
Copy link
Owner Author

simonwep commented Oct 8, 2019

@sdbrannum The idea is awesome! The only problem is that the background behind the border is still where which causes a transparency-pattern appearing behind the previous-color-button. Box-shadow also shrinks the element-size (I'm using box-sizing: border-box) which looks somehow weird and glitchy :/

@simonwep simonwep unpinned this issue Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed improvement Something could be improved
Projects
None yet
Development

No branches or pull requests

2 participants