Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An unclosed div element in $:/SplashScreen causes a 418 Invalid TiddlyWiki #311

Open
simonbaird opened this issue Jul 6, 2023 · 1 comment

Comments

@simonbaird
Copy link
Collaborator

simonbaird commented Jul 6, 2023

Tiddlyhost does some parsing of the document on serve, and the unclosed div effectively means it can't find tiddlers in the place it expects them to be.

The TiddlyWiki file itself work fine, so Tiddlyhost is more sensitive to the resulting dom irregularities than TiddlyWiki itself.

Sites affected by this can't be downloaded in the usual, since the same dom parsing happens on download.

Some ideas:

  • Try to catch the problem on save, and report a save failure or just quietly fix it on the fly.
  • Be looser about where to find the tiddler store in the dom.
  • Some kind of TiddlyWiki5 sanity checking for unclosed divs or other malformed html. (There's probably other ways to break TiddlyWiki itself so it might be worthwhile making that more robust for all TiddlyWiki users.
  • Make it a little easier to recover from this on Tiddlyhost by providing a "raw" download option in the actions menu.

Note that this same issue would apply to other tiddlers that insert content directly into the html file. I think $:/SpashScreen is not the only example.

@simonbaird
Copy link
Collaborator Author

simonbaird commented Aug 21, 2023

Looks like anything tagged with $:/tags/RawMarkupWikified/TopBody is going to be similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant