Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhpServer and PythonService decoupling. #391

Open
ilexei opened this issue Jan 3, 2025 · 0 comments
Open

PhpServer and PythonService decoupling. #391

ilexei opened this issue Jan 3, 2025 · 0 comments

Comments

@ilexei
Copy link

ilexei commented Jan 3, 2025

Right now main PhpService and PythonService are connected to the same machine, basically, due to several things.

  1. Python Service port. It is hardcoded as :8678 in PHP. I would propose make it an env variable for PHP and Python (tested it already - it is working).
  2. There is am implicit connection via filesystem. I discovered that subtitle files are stored by PHP and Python Service is reading them directly from the same disk. It is not working without file shares, when services are deployed to different servers. Workaround is to add file share (which is quite expensive) or send the file itself through the API, so that python could save it itself and then parse. It could be a breaking change, if anyone is using containers on different servers - they will have to redeploy both containers.
  3. Unfortunately, I don't know if any other APIs use the same filesystem for other operations. If you could help me finding it, I could propose a fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant