Skip to content

Commit 1316c96

Browse files
committed
added editable attribute to mini editor
1 parent 7571ad1 commit 1316c96

File tree

4 files changed

+11
-0
lines changed

4 files changed

+11
-0
lines changed

web/components/basic_modals.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ export function Prompt({
4747
onChange={(text) => {
4848
setText(text);
4949
}}
50+
editable={true}
5051
/>
5152
<div className="sb-prompt-buttons">
5253
<Button

web/components/filter.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -211,6 +211,7 @@ export function FilterList({
211211

212212
return true;
213213
}}
214+
editable={true}
214215
/>
215216
</div>
216217
<div

web/components/mini_editor.tsx

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ export function MiniEditor(
4343
onChange,
4444
focus,
4545
completer,
46+
editable,
4647
}: {
4748
text: string;
4849
placeholderText?: string;
@@ -53,6 +54,7 @@ export function MiniEditor(
5354
completer?: (
5455
context: CompletionContext,
5556
) => Promise<CompletionResult | null>;
57+
editable: boolean;
5658
} & MiniEditorEvents,
5759
) {
5860
const editorDiv = useRef<HTMLDivElement>(null);
@@ -156,6 +158,11 @@ export function MiniEditor(
156158
EditorView.theme({}, { dark: darkMode }),
157159
// Enable vim mode, or not
158160
[...vimMode ? [vim()] : []],
161+
[
162+
...editable
163+
? []
164+
: [EditorView.editable.of(false), EditorState.readOnly.of(true)],
165+
],
159166

160167
autocompletion({
161168
override: completer ? [completer] : [],

web/components/top_bar.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,8 @@ export function TopBar({
9191
onEnter={(newName) => {
9292
onRename(newName);
9393
}}
94+
editable={!client.ui.viewState.uiOptions.forcedROMode &&
95+
!client.clientConfig.readOnly}
9496
/>
9597
</span>
9698
{notifications.length > 0 && (

0 commit comments

Comments
 (0)