Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject attestations to blocks prior to the split #7083

Open
michaelsproul opened this issue Mar 6, 2025 · 1 comment · May be fixed by #7084
Open

Reject attestations to blocks prior to the split #7083

michaelsproul opened this issue Mar 6, 2025 · 1 comment · May be fixed by #7084
Labels
UX-and-logs v7.0.0-beta.clean Clean release post Holesky rescue

Comments

@michaelsproul
Copy link
Member

michaelsproul commented Mar 6, 2025

With manual finalization, we added checks to reject blocks that conflict with the split point, which are effectively finalized.

We didn't add any checks to reject similar attestations. This is leading to a lot of noisy cache miss logs and "failed promises" in the committee cache on Holesky.

Mar 06 03:47:03.153 DEBG Committee cache miss head_block_root: 0xe156a286e3a24c81a5afb2c4a47cbd1a75be4ea25f5670c08dc5837a053244d1, shuffling_id: Epoch(118047), service: beacon

Mar 06 03:47:14.357 WARN State cache missed backtrace: 0: store::hot_cold_store::HotColdDB<E,Hot,Cold>::get_advanced_hot_state 1: network::network_beacon_processor::gossip_methods::<impl network::network_beacon_processor::NetworkBeaconProcessor>::process_gossip_attestation_to_convert 2: core::ops::function::FnOnce::call_once{{vtable.shim}} 3: tokio::runtime::task::raw::poll 4: std::sys::backtrace::__rust_begin_short_backtrace 5: core::ops::function::FnOnce::call_once{{vtable.shim}} 6: std::sys::pal::unix::thread::Thread::new::thread_start 7: 8:

Mar 06 03:47:14.366 DEBG Invalid attestation from network type: "unaggregated", peer_id: 16Uiu2HAmLAWYx8PBL8CQRTQAGLLvRtdMK2B7b4exaPju2fkLt57h, block: 0xe156a286e3a24c81a5afb2c4a47cbd1a75be4ea25f5670c08dc5837a053244d1, reason: BeaconChainError(MissingBeaconState(0x08f94dfd6adc67d6cfee4c4a99ecb2f53042f9808c7697f785292a2a141ac706))

This doesn't seem to have much performance impact, as no states end up being actually loaded from disk, however it does obscure legitimate state cache and committee cache misses, which is not ideal.

@michaelsproul michaelsproul added UX-and-logs v7.0.0-beta.clean Clean release post Holesky rescue labels Mar 6, 2025
@eserilev
Copy link
Collaborator

eserilev commented Mar 6, 2025

I can pick this one up

@eserilev eserilev linked a pull request Mar 6, 2025 that will close this issue
@eserilev eserilev linked a pull request Mar 6, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UX-and-logs v7.0.0-beta.clean Clean release post Holesky rescue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants