-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update dashboard panels layout and positioning #933
feat: Update dashboard panels layout and positioning #933
Conversation
@navyayy can you adjust the x,y params such that there are only 2 panels in one row. You can increase width by 1 . |
@sunitakawane Okay, I will update it. |
…iglens#932) * logsearch page -Wildcard Option, Index Search * address PR comments --------- Co-authored-by: Kunal Nawale <[email protected]>
Co-authored-by: Kunal Nawale <[email protected]>
* Add <aggregation>_over_time funcs processing logic * Add <aggregation>_over_time funcs parsing logic * Add metrics prompt json * Add unit tests * Add e2e tests * Remove unused code * Add unit tests
Co-authored-by: Kunal Nawale <[email protected]>
* Fix interleaved socket timings * Make doSearch return a promise --------- Co-authored-by: Sonam Gupta <[email protected]>
Co-authored-by: Sonam Gupta <[email protected]>
* Add qid to the log msg * Fix unrotated segment range checking logic
* Allow parsing promql trigonometric functions * Add promql trigonometric functions processing logic * Add metrics prompt json * Add unit tests * Fix up
* Fix up * Add promql funcs parsing logic * Add promql funcs processing logic * Add metrics prompt json * Add test cases --------- Co-authored-by: Andrew Hess <[email protected]>
* Remove live tail on UI * remove live tail
…lens#949) * Increase tolerance for approximate equality in metrics test * Fix up
* Add metrics and traces count * address ineff assign --------- Co-authored-by: Andrew Hess <[email protected]>
* Store all incoming queries to query.log * optimize file handling and log restart events * use common method for logging * rename mu to fileMutex
* Truncate slices to discard stale data The SegmentFileReader.deTlv in particular was holding on to stale data and then iterating over it; sometimes leading to getting garbage data, and other times causing a panic. * Add basic unit test * Update the unit test * Fix linting
…of_year,days_in_month (siglens#937) * Add promql funcs promql functions hour(),minute(),month(),year(),day_of_month(),day_of_week(),day_of_year(),days_in_month() * add testcases * add cicd tests and update var names * update example queries * formatting * address comments * update desc --------- Signed-off-by: Venkatesha Matam <[email protected]> Co-authored-by: Andrew Hess <[email protected]>
Signed-off-by: Kunal Nawale <[email protected]>
* Refactor sending http errors * Add unit test --------- Co-authored-by: Kunal Nawale <[email protected]>
* Add util to resize a slice * Expand to capacity to avoid unnecessary appending * Refactor to use ResizeSlice() util --------- Co-authored-by: Kunal Nawale <[email protected]>
Co-authored-by: Kunal Nawale <[email protected]>
Signed-off-by: Kunal Nawale <[email protected]>
@sunitakawane I have updated the panels and also the screenshots in the description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Description
The height
h
and widthw
of the JSON files of dashboards have been changed, to accommodate the new height and width standards, which was previously pixels.Fixes #922
Testing
The following dashboards are verified:
![image](https://private-user-images.githubusercontent.com/108896805/334252434-9d2fbc01-2a8b-430c-ad70-abd9824ec1ce.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkxMDM0NTAsIm5iZiI6MTcxOTEwMzE1MCwicGF0aCI6Ii8xMDg4OTY4MDUvMzM0MjUyNDM0LTlkMmZiYzAxLTJhOGItNDMwYy1hZDcwLWFiZDk4MjRlYzFjZS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNjIzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDYyM1QwMDM5MTBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0yZDJhNzc2YjY0NzJiMzFmZWZiMTc0Mzc0Y2Q4YTViOThiYzNiNTAyNzBlYWE3MDMzYjJhZWU1ODAzOGM1ZjhhJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.cs4zGC3KuK9u55wPeqmYspQiy8uwwGPO3_UPr_sgxiE)
![image](https://private-user-images.githubusercontent.com/108896805/334252505-03d807bb-d181-4ecb-9c7d-87b8a46ecce9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkxMDM0NTAsIm5iZiI6MTcxOTEwMzE1MCwicGF0aCI6Ii8xMDg4OTY4MDUvMzM0MjUyNTA1LTAzZDgwN2JiLWQxODEtNGVjYi05YzdkLTg3YjhhNDZlY2NlOS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNjIzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDYyM1QwMDM5MTBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0wMmFlMzA4NTYxZmRlMzUxOGRmYmEwYjMxYTU1NTNmN2M3ZDQyYTc3MDJlZmQ1MDAzYWQyMTdiNmZhZTQ3ZmE2JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9._2HXdWCTMADFM2X30Rr2BwWpd_llOX-ab-O68-lAEag)
![image](https://private-user-images.githubusercontent.com/108896805/334252538-5177b45c-584f-49a5-b899-fa1c8b6a090f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkxMDM0NTAsIm5iZiI6MTcxOTEwMzE1MCwicGF0aCI6Ii8xMDg4OTY4MDUvMzM0MjUyNTM4LTUxNzdiNDVjLTU4NGYtNDlhNS1iODk5LWZhMWM4YjZhMDkwZi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNjIzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDYyM1QwMDM5MTBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0xNzQyYjgzODY4NTU4ZjMxNDY1NDljOGQ2ODdhNWRiMDhiZmNjMWYwZTQ0MTM3NTNhZGY5Mzc5MzY1NjM1OGFhJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.TEkWyVOsSBuoIsWQxTKF2PgQuGmd8b59iD6hllr3G6A)
![Uploading image.png…]()
Checklist:
Before marking your pull request as ready for review, complete the following.
goimports -w .
.