Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update dashboard panels layout and positioning #933

Merged
merged 36 commits into from
May 29, 2024

Conversation

navyayy
Copy link
Contributor

@navyayy navyayy commented May 22, 2024

Description

The height h and width w of the JSON files of dashboards have been changed, to accommodate the new height and width standards, which was previously pixels.

Fixes #922

Testing

The following dashboards are verified:
image
image
image
Uploading image.png…

Checklist:

Before marking your pull request as ready for review, complete the following.

  • I have self-reviewed this PR.
  • I have removed all print-debugging and commented-out code that should not be merged.
  • I have added sufficient comments in my code, particularly in hard-to-understand areas.
  • I have formatted the code, if applicable. For Go, I have run goimports -w ..

@sunitakawane
Copy link
Collaborator

@navyayy can you adjust the x,y params such that there are only 2 panels in one row. You can increase width by 1 .

@navyayy
Copy link
Contributor Author

navyayy commented May 23, 2024

@navyayy can you adjust the x,y params such that there are only 2 panels in one row. You can increase width by 1 .

@sunitakawane Okay, I will update it.

Jiale-Fang and others added 21 commits May 28, 2024 07:56
…iglens#932)

* logsearch page -Wildcard Option, Index Search

* address PR comments

---------

Co-authored-by: Kunal Nawale <[email protected]>
* Add <aggregation>_over_time funcs processing logic

* Add <aggregation>_over_time funcs parsing logic

* Add metrics prompt json

* Add unit tests

* Add e2e tests

* Remove unused code

* Add unit tests
* Fix interleaved socket timings

* Make doSearch return a promise

---------

Co-authored-by: Sonam Gupta <[email protected]>
* Add qid to the log msg

* Fix unrotated segment range checking logic
* Allow parsing promql trigonometric functions

* Add promql trigonometric functions processing logic

* Add metrics prompt json

* Add unit tests

* Fix up
* Fix up

* Add promql funcs parsing logic

* Add promql funcs processing logic

* Add metrics prompt json

* Add test cases

---------

Co-authored-by: Andrew Hess <[email protected]>
* Remove live tail on UI

* remove live tail
…lens#949)

* Increase tolerance for approximate equality in metrics test

* Fix up
* Add metrics and traces count

* address ineff assign

---------

Co-authored-by: Andrew Hess <[email protected]>
* Store all incoming queries to query.log

* optimize file handling and log restart events

* use common method for logging

* rename mu to fileMutex
* Truncate slices to discard stale data

The SegmentFileReader.deTlv in particular was holding on to stale data
and then iterating over it; sometimes leading to getting garbage data,
and other times causing a panic.

* Add basic unit test

* Update the unit test

* Fix linting
…of_year,days_in_month (siglens#937)

* Add promql funcs

promql functions hour(),minute(),month(),year(),day_of_month(),day_of_week(),day_of_year(),days_in_month()

* add testcases

* add cicd tests and update var names

* update example queries

* formatting

* address comments

* update desc

---------

Signed-off-by: Venkatesha Matam <[email protected]>
Co-authored-by: Andrew Hess <[email protected]>
* Refactor sending http errors

* Add unit test

---------

Co-authored-by: Kunal Nawale <[email protected]>
* Add util to resize a slice

* Expand to capacity to avoid unnecessary appending

* Refactor to use ResizeSlice() util

---------

Co-authored-by: Kunal Nawale <[email protected]>
@navyayy
Copy link
Contributor Author

navyayy commented May 28, 2024

@navyayy can you adjust the x,y params such that there are only 2 panels in one row. You can increase width by 1 .

@sunitakawane I have updated the panels and also the screenshots in the description.

Copy link
Collaborator

@sonamgupta21 sonamgupta21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

static/js/dashboard.js Outdated Show resolved Hide resolved
@sonamgupta21 sonamgupta21 merged commit 79ab40d into siglens:develop May 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI - Update Default Dashboard Dimensions According to New Library
7 participants