New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client flags not limited to server capabilities #2261
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For some unknown reason, Metabase fails to return a handshake when the server advertises CLIENT_CONNECT_ATTRS. Attempting to remove CLIENT_CONNECT_ATTRS from a
mysql2
server led me to confirm the following:mysql2
server doesn't set CLIENT_CONNECT_ATTRS, clients ( themysql
CLI and Metabase) still respond with CLIENT_CONNECT_ATTRS set.mysql2
accepts whatever flags the client sends in the handshake response.mysql2
reads off the end of the handshake buffer (Should not reach here: undefined
) trying to read the client attributes.The TL;DR is that if I patch
mysql2
to OR the server capabilities and client flags (which I believe is what the protocol specifies), handshakes succeed in all cases.For reference, here are the handshake packets returned:
The text was updated successfully, but these errors were encountered: