Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many requirements + Other #1

Open
dieperdev opened this issue Apr 1, 2024 · 9 comments
Open

Too many requirements + Other #1

dieperdev opened this issue Apr 1, 2024 · 9 comments
Labels
good first issue Good for newcomers

Comments

@dieperdev
Copy link

Requirements issue:
Your requirements.txt file looks like it has a lot of requirements that aren’t necessary for the project. I’ve looked through all the files and I can confirm there isn’t 200 lines of imports. You may want to check the dependencies again.

Other thoughts:

  • Rather than using a ton of os.system statements in main.py, you could import the functions and use the code that would be run there.
  • Put your __pycache__ folder in your .gitignore file.
  • Place other files (if they’re necessary) displayed in your README file into a separate folder to prevent confusion. Otherwise place these files in your .gitignore too.
@shreesha345
Copy link
Owner

thank you for opening a issue

@shreesha345
Copy link
Owner

shreesha345 commented Apr 1, 2024

I would look into the requirements and the issue what you have said and I would update it.
currently I am working on something else and I need time for that so I would appreciate if your could do a pull request for those changes.

@dieperdev
Copy link
Author

@shreesha345 It seems like you have a few files in a location that isn't accessible through the program. Are they supposed to be added? These include the following:

  • D:\AI-video-maker\Final work\caption\src\Root.tsx
  • D:\AI-video-maker\Final work\output\best_video_2.mp4
  • D:\AI-video-maker\final work\subtitles.srt
  • and the output directory D:\AI-video-maker\final work\raw_video

@shreesha345
Copy link
Owner

I have done some Mistake in the path I feel

@shreesha345
Copy link
Owner

I am still a beginner in python programming so I would appreciate if you could help me to fix these

@dieperdev
Copy link
Author

Sorry for the delay, but are the rest of the files listed above in any way related to the program?

@shreesha345
Copy link
Owner

shreesha345 commented Apr 29, 2024

Yes it is uses but you just replace it with these:
D:\AI-video-maker\caption\src\Root.tsx
D:\AI-video-maker\output\best_video_2.mp4
D:\AI-video-maker\subtitles.srt
D:\AI-video-maker\raw_video

@dieperdev
Copy link
Author

I think you should upload those files to the repo then.

@shreesha345 shreesha345 added the good first issue Good for newcomers label Aug 11, 2024
@shreesha345
Copy link
Owner

@dieperdev if you try running this it might fix it.
AI-short-creator\caption\src\Root.tsx
AI-short-creator\output
D:\AI-short-creator\subtitles.srt
D:\AI-short-creator\raw_video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants