You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 17, 2020. It is now read-only.
Describe the bug
Browser complains about graphQLError.extensions property being undefined if a null long link is attempted to be converted to string by user short links section. This seems to be because the error response is assumed to contain the extensions field.
To Reproduce
Change any short link's long link to null
Set user-short-links-section feature to true in app/usecase/feature/static.go
Reload frontend homepage
Expected behavior
An error for loading the offending long link should be displayed.
Screenshots
Additional context
Although null long link is indeed an error, a more sensible error should be displayed to the screen if this happens. Additionally, either the extensions property should be defined within the response of this error from backend, or the frontend should check for existence of this property before retrieving the extension code.
The text was updated successfully, but these errors were encountered:
Describe the bug
Browser complains about
graphQLError.extensions
property being undefined if a null long link is attempted to be converted to string by user short links section. This seems to be because the error response is assumed to contain theextensions
field.To Reproduce
null
user-short-links-section
feature totrue
inapp/usecase/feature/static.go
Expected behavior
An error for loading the offending long link should be displayed.
Screenshots
Additional context
Although null long link is indeed an error, a more sensible error should be displayed to the screen if this happens. Additionally, either the
extensions
property should be defined within the response of this error from backend, or the frontend should check for existence of this property before retrieving the extension code.The text was updated successfully, but these errors were encountered: