Skip to content
This repository has been archived by the owner on Oct 17, 2020. It is now read-only.

[Feature] Add loading page component #816

Open
rohithbalaji123 opened this issue May 26, 2020 · 4 comments
Open

[Feature] Add loading page component #816

rohithbalaji123 opened this issue May 26, 2020 · 4 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers p2 Low priority

Comments

@rohithbalaji123
Copy link
Member

What is the problem?
When visiting a page whose availability is determined from the server state, there is a time lag before the response is shown to the user.

Your solution
We can show an intermediate loading page to let users know that we have received the request and the server is validating the page access request.

Alternatives considered
Currently, an empty page is shown. If having a loading page is found to add resource overhead, we can leave it as such.

Additional context
When a user goes to an auth protected route, say admin panel, there is a network call made to determine if the page is accessible. I have added a 2 second delay in server to show the need for this in the following GIF.

loading

@rohithbalaji123 rohithbalaji123 added enhancement New feature or request p2 Low priority labels May 26, 2020
@magicoder10
Copy link
Member

magicoder10 commented May 26, 2020

I wonder why did it take so long to load. Is it purely network latency? We can use Chrome profile tool to find out what's exactly going on here.

Both loading animation and server side rendering sound good to me.

@magicoder10 magicoder10 added the good first issue Good for newcomers label May 26, 2020
@rohithbalaji123
Copy link
Member Author

@byliuyang

Additional context

When a user goes to an auth protected route, say admin panel, there is a network call made to determine if the page is accessible. I have added a 2 second delay in server to show the need for this in the following GIF.

@magicoder10
Copy link
Member

@rohithbalaji123 Oh! Sorry for missing that.

@Coteh
Copy link
Collaborator

Coteh commented Jun 13, 2020

Interested in taking this!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers p2 Low priority
Projects
None yet
Development

No branches or pull requests

3 participants