-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/v2/signin service #1428
Comments
@sebastienbeau ^ have you thought about verified emails on partners yet? |
When /signin is called:
|
Can we avoid binding this to JWT only? This API should be shared across all kinds of auth types. N'est pas? |
Maybe. I don't know how to generalize that yet, though. In I'd say we need someone to explore how it would work with another authentication mechanism first, and then we can look at unifying things, if at all possible. That said, the logic to convert an anonymous partner/cart to a known one could live elsewhere than |
For the record; our current implementation of this in v14 is #1251 We took care of some of the corner cases. |
Maybe the logic to transfer a cart from one partner to another could go in |
I was thinking of this. To me it makes more sense.
Regarding when to create the anon partner... When do you expect this to happen? (I've left a comment on the PR). A possibile scenario could be that the customer clicks on "add to cart" and if not authenticated, it is asked to register or to continue as guest and if the last choice is taken you call |
Attention points / open questions:
email
field is populated with an unverified email? Maybe ashopinvader_verified_email
module with a simpleemail_verified
flag that we can set on partner creation, or let a backend user set if they are sure of the customer email.The text was updated successfully, but these errors were encountered: